Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel generators when the process exits #774

Closed
ehmicky opened this issue Feb 2, 2024 · 0 comments · Fixed by #783
Closed

Cancel generators when the process exits #774

ehmicky opened this issue Feb 2, 2024 · 0 comments · Fixed by #783

Comments

@ehmicky
Copy link
Collaborator

ehmicky commented Feb 2, 2024

When passing a transform to the stdin option, the generator function starts running.
If the process errors, the generator should stop the next time yield is called.
Currently, this is not the case. The generator keeps running until completion.

This bug could make the child process hang forever, for example when using a transform that generates values infinitely (like the Unix command yes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant