Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ArrayBuffer as input #193

Merged
merged 2 commits into from Apr 11, 2019
Merged

Conversation

razor-x
Copy link
Contributor

@razor-x razor-x commented Mar 29, 2019

Closes #191

@razor-x
Copy link
Contributor Author

razor-x commented Apr 8, 2019

@sindresorhus Anything else you need for a merge / release?

@sindresorhus
Copy link
Owner

You also need to update the readme.

@razor-x
Copy link
Contributor Author

razor-x commented Apr 10, 2019

Cool. I've updated all the spots that mentioned Uint8Array to include ArrayBuffer.

@razor-x
Copy link
Contributor Author

razor-x commented Apr 10, 2019

I'm not familiar with typescript, any thoughts on the CI error :|

  index.test-d.ts:8:59
  ✖  8:59  Argument of type number[] is not assignable to parameter of type number.  
  1 error
npm ERR! Test failed.  See above for more details.
The command "npm test" exited with 1.

@sindresorhus
Copy link
Owner

@razor-x Read the error. ArrayBuffer accepts a length (number) argument, not an array.

@sindresorhus sindresorhus changed the title Allow ArrayBuffer as input Allow ArrayBuffer as input Apr 11, 2019
Update docs and types with ArrayBuffer
@razor-x
Copy link
Contributor Author

razor-x commented Apr 11, 2019

Thanks :) Your translation is much clearer.

@sindresorhus sindresorhus merged commit b714ddd into sindresorhus:master Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants