Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positives test are broken #387

Closed
Borewit opened this issue Aug 24, 2020 · 1 comment · Fixed by #388
Closed

False positives test are broken #387

Borewit opened this issue Aug 24, 2020 · 1 comment · Fixed by #388
Labels

Comments

@Borewit
Copy link
Collaborator

Borewit commented Aug 24, 2020

Following Microsoft documents are not tested as .msi (Windows Installer) or [MS-CFB]: Compound File Binary File Format:

file-type/test.js

Lines 178 to 182 in 4a4d39c

msi: [
'fixture-ppt',
'fixture-doc',
'fixture-xls'
]

const FileType = require('file-type');
const path = require('path');

(async () => {
  const fileType = await FileType.fromFile(path.join('fixture', 'fixture-xls.msi'));
  console.log(fileType);
})();

Outputs:

undefined

Related:

@Borewit
Copy link
Collaborator Author

Borewit commented Aug 25, 2020

Ah, these files used to be false positives, but are no longer tested as false positives. It is not something like a known issue (known false positives).

The fix 702f795, to prevent false positives, seems to be more luck than wisdom, as it only narrows down to a specific version number of [MS-CFB]: Compound File Binary File Format:.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant