Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code examples provided in typing definition files have syntax errors #471

Closed
Borewit opened this issue Jul 22, 2021 · 2 comments
Closed
Labels

Comments

@Borewit
Copy link
Collaborator

Borewit commented Jul 22, 2021

Following import style, as found in embedded examples, is a kind of mix between TypeScript & JavaScript, I think.

import FileType = require('file-type');
@Borewit Borewit added the bug label Jul 22, 2021
@sindresorhus
Copy link
Owner

No, it's valid TypeScript syntax. However, I want to move to ESM, which will make this question moot: #468 (comment)

@Borewit
Copy link
Collaborator Author

Borewit commented Jul 22, 2021

Okay 👍🏻

@Borewit Borewit closed this as completed Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants