This changes whether a property is writable or configurable

[ehmicky]

The new properties returned by this library are always writable and configurable, even when the original properties were not. While non-writable or non-configurable properties are sometimes problematic, there are sometimes legitimate reasons for it. This seems to be an unintentional side effect.

const obj = Object.defineProperty({}, 'prop', { value: true, enumerable: true, writable: false, configurable: false })
const objCopy = includeKeys(obj, ['prop'])
console.log(Object.getOwnPropertyDescriptor(objCopy, 'prop'))
// { value: true, writable: true, enumerable: true, configurable: true }

Additionally, when a property is using get/set, they are currently removed.

const obj = Object.defineProperty({}, 'prop', { get: () => Math.random(), enumerable: true })
console.log(obj.prop, obj.prop) // Different random numbers
const objCopy = includeKeys(obj, ['prop'])
console.log(objCopy.prop, objCopy.prop) // Same random numbers

Instead of retrieving then copying the property values, the descriptors should be used instead.

filter-obj/index.js

Line 8 in 36e5f3a

const value = object[key];

filter-obj/index.js

Line 20 in 36e5f3a

const value = object[key];

Note: I can submit a PR.

[sindresorhus]

Thanks for catching that. PR welcome.

[ehmicky]

Done in #22.