Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to remove the vulnerability introduced by semver-regex? #8

Closed
evansrobert opened this issue Aug 8, 2021 · 5 comments
Closed

Comments

@evansrobert
Copy link

Subject of the issue

find-versions@3.2.0 requires semver-regex@2.0.0, which has a security problem (see: SNYK-JS-SEMVERREGEX-1047770):
find-versions@3.2.0 ➔ semver-regex@2.0.0

I do not know if this vulnerability actually affects find-versions, but it will show up in security reports about dependencies. Since a large number of developers still use find-versions@3.2.*(1,762,377 downloads per week), is there any posibility that you could release an update version for 3.2.* (ie 3.2.1) that introduces a patched version(>=3.1.2) of semver-regex?

In find-versions@3.2.1, maybe you can perform the following update:
semver-regex ^2.0.0 ➔ ^3.1.2
where semver-regex@3.1.2(>=3.1.2) has fixed the vulnerability SNYK-JS-SEMVERREGEX-1047770.

@Levdbas
Copy link

Levdbas commented Mar 17, 2022

Hi @sindresorhus , mind taking a look at this issue?

@sindresorhus
Copy link
Owner

In find-versions@3.2.1, maybe you can perform the following update:
semver-regex ^2.0.0 ➔ ^3.1.2

That is not possible. server-regex 3 requires Node.js 8, while find-versions 3 requires Node.js 6.

@sindresorhus
Copy link
Owner

I suggest upgrading find-versions.

@sindresorhus
Copy link
Owner

sindresorhus commented Mar 17, 2022

The "vulnerability" is a bullshit vulnerability anyway. Not every bug is a security vulnerability.

@sindresorhus
Copy link
Owner

Repository owner locked as resolved and limited conversation to collaborators Mar 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants