Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why is the 'fail' test not executed on windows? #16

Closed
alextes opened this issue Mar 29, 2017 · 5 comments · Fixed by #17
Closed

Why is the 'fail' test not executed on windows? #16

alextes opened this issue Mar 29, 2017 · 5 comments · Fixed by #17

Comments

@alextes
Copy link
Contributor

alextes commented Mar 29, 2017

No description provided.

@sindresorhus
Copy link
Owner

I don't know. I think it was a mistake in d39b693

@alextes
Copy link
Contributor Author

alextes commented Mar 29, 2017

Let's find out!

@alextes alextes mentioned this issue Mar 29, 2017
Merged
2 tasks
@alextes
Copy link
Contributor Author

alextes commented Mar 29, 2017

@sindresorhus so the test definitely fails on windows. The only question now is would you like taskkill to throw when a process is not found, or linux to not throw when a process is not found?

@sindresorhus
Copy link
Owner

The only question now is would you like taskkill to throw when a process is not found

Yes, silent fail is never good.

@alextes
Copy link
Contributor Author

alextes commented Mar 30, 2017 •
edited

I agree. I'll dive right in 🏊.
Have a great day @sindresorhus!

p.s. A monkey. Who would've thought?
It's actually a cat in a suit 😂 . Nevermind.

@alextes alextes mentioned this issue Apr 18, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Run 'fail' test on Windows too alextes/fkill
2 participants
@sindresorhus @alextes