Make extension optional in Windows #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will kill potentially unrelated programs, e.g. |
|
Yes, you are right. I will made some changes. |
|
Bump |
Fixed kill program with or without .exe
|
Done! |
sindresorhus
requested changes
Jun 15, 2019
| @@ -20,13 +20,25 @@ const missingBinaryError = async (command, arguments_) => { | |||
| } | |||
| }; | |||
|
|
|||
| const windowsKill = (input, options) => { | |||
| const killWithTask = (input, options) => { | |||
There was a problem hiding this comment.
Suggested change
| const killWithTask = (input, options) => { | |
| const killWithTaskkill = (input, options) => { |
| return taskkill(input, { | ||
| force: options.force, | ||
| tree: typeof options.tree === 'undefined' ? true : options.tree | ||
| }); | ||
| }; | ||
|
|
||
| const windowsKill = async (input, options) => { | ||
| try { | ||
| const firstTry = input; |
There was a problem hiding this comment.
There variables are not useful.
| const windowsKill = async (input, options) => { | ||
| try { | ||
| const firstTry = input; | ||
| return await killWithTask(firstTry, options); |
There was a problem hiding this comment.
Suggested change
| return await killWithTask(firstTry, options); | |
| return await killWithTask(input, options); |
| } catch (error) { | ||
| if (typeof input === 'string') { | ||
| const secondTry = input.concat('.exe'); | ||
| return killWithTask(secondTry, options); |
There was a problem hiding this comment.
Suggested change
| return killWithTask(secondTry, options); | |
| return killWithTask(input.concat('.exe'), options); |
| const firstTry = input; | ||
| return await killWithTask(firstTry, options); | ||
| } catch (error) { | ||
| if (typeof input === 'string') { |
There was a problem hiding this comment.
You are swallowing the error if it's not a string. When fixing this, also add a regression test.
| @@ -29,6 +29,15 @@ if (process.platform === 'win32') { | |||
| t.false(await processExists(pid)); | |||
| }); | |||
|
|
|||
| test.serial('win default without extension', async t => { | |||
There was a problem hiding this comment.
Suggested change
| test.serial('win default without extension', async t => { | |
| test.serial('window - supports extension-less process name', async t => { |
|
Support for this should be documented in readme and https://github.com/sindresorhus/fkill/blob/master/index.d.ts |
|
@luizwbr Still interested in finishing this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added '*' character to filter program's name, removing mandatory program extension.
Fixes #1