-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This module is not working for some cases #34
Comments
Are there any valid URLs in there? |
He's probably referring to |
Doesn't need the scheme part if it has |
I was expecting href="" and href='' to work as well. no relative urls |
Modify the code here to: const urls = text.match(urlRegex({ strict: false })) || []; That's it. |
i can confirm. I have a string containiing the url 'https://www.npmjs.com/package/get-urls' which it does not catch. |
this is my string: "so i load this module https://www.npmjs.com/package/get-urls" |
when i remove the www. it works |
I am trying to pass below contents into the function but no response is coming. Kindly check.
The text was updated successfully, but these errors were encountered: