Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work with mobile Safari or Chrome #74

Open
Madsim opened this issue Jul 15, 2021 · 1 comment
Open

Does not work with mobile Safari or Chrome #74

Madsim opened this issue Jul 15, 2021 · 1 comment

Comments

@Madsim
Copy link

Madsim commented Jul 15, 2021

I don't have the possibility to get an error message, but found this lib to crash our app on mobile.
It's enough to import it, to cause the problem.

import getUrls from 'get-urls'

Update:

The Problem seems to be caused by normalize-url.

This "solves" it:
// const normalizeUrl = require('normalize-url'); const normalizeUrl = url => url

Tracked it down to one line in an old version of normalize-url, that is used by this lib. Maybe it is fixes by just updating the dep.

@holtwick
Copy link

holtwick commented Sep 1, 2021

Same here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants