Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AsyncSequence #103

Closed
sindresorhus opened this issue Aug 4, 2019 · 0 comments
Closed

Use AsyncSequence #103

sindresorhus opened this issue Aug 4, 2019 · 0 comments

Comments

@sindresorhus
Copy link
Owner

sindresorhus commented Aug 4, 2019

When we can target macOS 12.

https://github.com/apple/swift-evolution/blob/main/proposals/0314-async-stream.md

We have a lot of asynchronicity and some of our code is hard to reason about. This change will make it both more readable and also let us get rid of Progress (NSProgress) which is very quirky and not well documented.

For example, this piece would benefit from using AsyncStream:

func generateCGImagesAsynchronously(


Apple provides it for us: https://developer.apple.com/documentation/avfoundation/avassetimagegenerator/3967579-images?changes=_2

@sindresorhus sindresorhus changed the title Use Combine Use AsyncSequence Jun 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@sindresorhus and others