Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lines property to Tooltip, alongside maxWidth #115

Closed
sunshinejr opened this issue Aug 7, 2019 · 2 comments
Closed

Add lines property to Tooltip, alongside maxWidth #115

sunshinejr opened this issue Aug 7, 2019 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@sunshinejr
Copy link
Contributor

Currently our Tooltip class uses the maxWidth property to size itself properly. We want to be able to just specify lines instead so it sizes itself based on that (similar to label).
@sunshinejr sunshinejr added enhancement New feature or request help wanted Extra attention is needed labels Aug 7, 2019
@sindresorhus
Copy link
Owner

It should still be possible to set maxWidth though. It can be useful when the content is dynamic. maxWidth should take precedence over lines.

@sindresorhus sindresorhus changed the title Replace maxWidth with lines property for Tooltip. Replace maxWidth with lines property for Tooltip Aug 7, 2019
@sunshinejr sunshinejr changed the title Replace maxWidth with lines property for Tooltip Add lines property to Tooltip, alongside maxWidth Aug 7, 2019
@sindresorhus
Copy link
Owner

Closing as this will be moot when we eventually rewrite in SwiftUI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sindresorhus @sunshinejr and others