Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Produces empty GIF for very short video #231

Closed
sindresorhus opened this issue Feb 9, 2021 · 1 comment · Fixed by #243
Closed

Produces empty GIF for very short video #231

sindresorhus opened this issue Feb 9, 2021 · 1 comment · Fixed by #243
Labels
bug Something isn't working

Comments

@sindresorhus
Copy link
Owner

@kornelski #222 introduced an issue where this video produces an empty invalid file: Short.mp4.zip

Before this change:

Short

After:

Short.gif.zip

I realize the video is way too short and weird, but we should never produce an invalid GIF. According to logging, it successfully generated 2 frames and passed them to libgifski.
@sindresorhus sindresorhus added the bug Something isn't working label Feb 9, 2021
@kornelski
Copy link
Collaborator

Fixed in ImageOptim/gifski@2f62fbe

@sindresorhus sindresorhus mentioned this issue Jun 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade libgifski to 1.4.4 sindresorhus/Gifski
2 participants
@kornelski @sindresorhus