Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Becomes default player for mp4 files #40

Closed
eonist opened this Issue Jul 11, 2018 · 5 comments

Comments

Projects
None yet
2 participants
@eonist
Copy link

eonist commented Jul 11, 2018

Quicktime should be the designated app to open .mp4. Manually setting gifski to open all mp4 is ok. Setting it by default on install, is a bit overreaching IMO.

Best gif app since Drop2Gif. Gave it 5 stars on the App Store. ✌️

@sindresorhus

This comment has been minimized.

Copy link
Owner

sindresorhus commented Jul 11, 2018

This was fixed in Gifski 1.3.0 (Latest version on the App Store): a238e03

@sindresorhus

This comment has been minimized.

Copy link
Owner

sindresorhus commented Jul 11, 2018

Best gif app since Drop2Gif. Gave it 5 stars on the App Store. ✌️

🤩

@eonist

This comment has been minimized.

Copy link
Author

eonist commented Jul 11, 2018

OK, I just downloaded the app 10 minutes ago. Maybe the Norwegian App Store is out of date or something. I tried to look for the bug in issue search but couldn't find it, so thought I would mention it. I have version Version 1.3.0 (5) And its the only version I have tried. Also the App Store says v 1.2.1 whatever that corresponds to.

@eonist eonist closed this Jul 11, 2018

@eonist eonist reopened this Jul 11, 2018

@sindresorhus

This comment has been minimized.

Copy link
Owner

sindresorhus commented Jul 11, 2018

Hmm...

Determines how Launch Services ranks this app among the apps that declare themselves editors or viewers of files of this type. The possible values are: Owner (this app is the primary creator of files of this type), Default (this app is an opener of files of this type; this value is also used if no rank is specified), Alternate (this app is a secondary viewer of files of this type), and None (this app is never selected to open files of this type, but it accepts drops of files of this type). Launch Services uses the value of LSHandlerRank to determine the app to use to open files of this type. The order of precedence is: Owner, Default, Alternate. This key is available in macOS 10.5 and later and iOS 3.0 and later. - https://developer.apple.com/library/archive/documentation/General/Reference/InfoPlistKeyReference/Articles/CoreFoundationKeys.html#//apple_ref/doc/uid/TP40009249-101685-TPXREF107

I assumed Alternative would make it still prefer the system apps, but it seems that's not true. Setting it to None is not an option either as then Gifski doesn't show up in the "Open With" menu.

@sindresorhus

This comment has been minimized.

Copy link
Owner

sindresorhus commented Jul 11, 2018

Ok, looking at other video conversion apps, it seems all of them declare themselves as a Viewer and not Editor, so I guess that's the issue.


<dict>
	<key>CFBundleTypeExtensions</key>
	<array>
		<string>mp4</string>
	</array>
	<key>CFBundleTypeName</key>
	<string>MPEG-4 FIle</string>
	<key>CFBundleTypeRole</key>
	<string>Viewer</string>
</dict>
<dict>
	<key>CFBundleTypeMIMETypes</key>
	<array/>
	<key>CFBundleTypeName</key>
	<string>GIF Brewery 3 Supported Videos</string>
	<key>CFBundleTypeRole</key>
	<string>Viewer</string>
	<key>LSItemContentTypes</key>
	<array>
		<string>public.dv-movie</string>
		<string>public.3gpp</string>
		<string>public.3gpp2</string>
		<string>com.apple.m4v-video</string>
		<string>public.mpeg-2-video</string>
		<string>public.mpeg-4</string>
		<string>com.apple.quicktime-movie</string>
	</array>
	<key>LSTypeIsPackage</key>
	<integer>0</integer>
	<key>NSDocumentClass</key>
	<string>HRDocument</string>
</dict>
<dict>
	<key>CFBundleTypeName</key>
	<string>Media File</string>
	<key>CFBundleTypeRole</key>
	<string>Viewer</string>
	<key>LSItemContentTypes</key>
	<array>
		<string>public.data</string>
		<string>public.audio</string>
		<string>public.movie</string>
		<string>public.mpeg</string>
		<string>com.apple.quicktime-movie</string>
		<string>public.avi</string>
		<string>public.mpeg-4</string>
		<string>public.3gpp2</string>
		<string>public.3gpp</string>
	</array>
</dict>

sindresorhus added a commit to wulkano/kap that referenced this issue Aug 15, 2018

Set `CFBundleTypeRole` to `Viewer`
We don't want Kap to become the default player for MP4 files, see: sindresorhus/gifski-app#40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.