Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gifski library #51

Closed
sindresorhus opened this issue Jan 18, 2019 · 4 comments · Fixed by #90
Closed

Update gifski library #51

sindresorhus opened this issue Jan 18, 2019 · 4 comments · Fixed by #90
Assignees

Comments

@sindresorhus
Copy link
Owner

@kornelski Would you be able to update https://github.com/ImageOptim/gifski/tree/master/gifski.xcodeproj to latest Xcode and then update the gifski library in this repo? I noticed it has had a bunch of improvements since the last time we updated: ImageOptim/gifski@94d6339...master

@sindresorhus
Copy link
Owner Author

I'm also seeing a bunch of warnings when compiling now:

:-1: object file (/Users/sindresorhus/Library/Developer/Xcode/DerivedData/Gifski-czyyuqkvdbamwdbhqpunkswgmddo/Build/Products/Debug/libgifski.a(state.o)) was built for newer OSX version (10.14) than being linked (10.13)

I assume we need to set the target macOS version somewhere, but not sure where.

@kornelski
Copy link
Collaborator

The target version is set via MACOSX_DEPLOYMENT_TARGET env var. I'm surprised that you see this, because Xcode generally sets it itself. Check the build log in Xcode — maybe some Xcode target has wrong deployment target set.

@kornelski
Copy link
Collaborator

The changes so far were cosmetic, so no rush. As I've mentioned in another thread, I want to make the C API more C-ish, so I'll have a bigger update "soon"

@kornelski kornelski self-assigned this Jan 18, 2019
@kornelski kornelski pinned this issue Jan 18, 2019
@kornelski kornelski unpinned this issue Jan 18, 2019
@sindresorhus
Copy link
Owner Author

The target version is set via MACOSX_DEPLOYMENT_TARGET env var. I'm surprised that you see this, because Xcode generally sets it itself. Check the build log in Xcode — maybe some Xcode target has wrong deployment target set.

It did indeed have the wrong deploy target, but even after fixing that (03543bd), I still see the warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants