Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notification when Gifski completed the conversion #82

Closed
sunshinejr opened this issue May 14, 2019 · 1 comment · Fixed by #86
Closed

Notification when Gifski completed the conversion #82

sunshinejr opened this issue May 14, 2019 · 1 comment · Fixed by #86
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@sunshinejr
Copy link
Contributor

There are times that it takes time to convert the GIF, and having hidden dock I have to check few times if the conversion completed. It would be awesome to have a notification that would respect DND (similar to Xcode builds).
@sindresorhus sindresorhus changed the title Notification when Gifski completed the convertion. Notification when Gifski completed the conversion May 14, 2019
@sindresorhus sindresorhus added enhancement New feature or request help wanted Extra attention is needed labels May 14, 2019
@sindresorhus
Copy link
Owner

sindresorhus commented May 14, 2019 •
edited

That's a good idea. I'm surprised I didn't think of this myself.

I think we should only show a notification if the window is not focused when the conversion is completed.

sindresorhus added a commit that referenced this issue Jun 21, 2019
@sindresorhus
Show notification when the conversion is completed
c33d637 
Fixes #82
@sindresorhus sindresorhus mentioned this issue Jun 21, 2019
Merged
sindresorhus added a commit that referenced this issue Jun 22, 2019
@sindresorhus
Show a notification when the conversion is completed (#86)
7929e86 
Fixes #82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show a notification when the conversion is completed sindresorhus/Gifski
2 participants
@sindresorhus @sunshinejr