Improve the legibility of the progress circle in dark mode (#178)

sindresorhus · Feb 10, 2020 · 8e152d3 · 8e152d3
1 parent ab927d0
commit 8e152d3
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 2 deletions.
diff --git a/Gifski/Assets.xcassets/ProgressCircleColor.colorset/Contents.json b/Gifski/Assets.xcassets/ProgressCircleColor.colorset/Contents.json
@@ -0,0 +1,28 @@
+{
+  "info" : {
+    "version" : 1,
+    "author" : "xcode"
+  },
+  "colors" : [
+    {
+      "idiom" : "mac",
+      "color" : {
+        "platform" : "osx",
+        "reference" : "controlAccentColor"
+      }
+    },
+    {
+      "idiom" : "mac",
+      "appearances" : [
+        {
+          "appearance" : "luminosity",
+          "value" : "dark"
+        }
+      ],
+      "color" : {
+        "platform" : "osx",
+        "reference" : "labelColor"
+      }
+    }
+  ]
+}
diff --git a/Gifski/Constants.swift b/Gifski/Constants.swift
@@ -9,6 +9,7 @@ struct Constants {
 
 extension NSColor {
 	static let themeColor = NSColor.controlAccentColorPolyfill
+	static let progressCircleColor = NSColor(named: "ProgressCircleColor")!
 
 	enum Checkerboard {
 		static let first = NSColor(named: "CheckerboardFirstColor")!

diff --git a/Gifski/ConversionViewController.swift b/Gifski/ConversionViewController.swift
@@ -6,14 +6,15 @@ import Defaults
 final class ConversionViewController: NSViewController {
 	private lazy var circularProgress = with(CircularProgress(size: 160.0)) {
 		$0.translatesAutoresizingMaskIntoConstraints = false
-		$0.color = .themeColor
+		$0.color = .progressCircleColor
+		$0.lineWidth = 3
 	}
 
 	private lazy var timeRemainingLabel = with(Label()) {
 		$0.translatesAutoresizingMaskIntoConstraints = false
 		$0.isHidden = true
 		$0.textColor = .secondaryLabelColor
-		$0.font = NSFont.monospacedDigitSystemFont(ofSize: 12, weight: .regular)
+		$0.font = .monospacedDigitSystemFont(ofSize: 12, weight: .regular)
 	}
 
 	private lazy var timeRemainingEstimator = TimeRemainingEstimator(label: timeRemainingLabel)