Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the remote name configurable #8

Closed
Deuchnord opened this issue Dec 9, 2019 · 5 comments · Fixed by #9
Closed

Make the remote name configurable #8

Deuchnord opened this issue Dec 9, 2019 · 5 comments · Fixed by #9

Comments

@Deuchnord
Copy link
Contributor

In some configurations, we can have to work on a fork instead of the original repository. In such situations, the original repository may have another name for more comfort, e.g. upstream, origin being the remote name for the fork.

Currently, this library doesn't take in account this case. Is it possible to add a new argument to the function exported, so we can tell it which remote name we want the URL from?

@RichardLitt
Copy link

I don't see why it wouldn't be possible to create a PR for this. But at that point, maybe a more general git-remote-url library would be more useful?

@Deuchnord
Copy link
Contributor Author

I don't see why it wouldn't be possible to create a PR for this.

I was actually proposing this before opening a PR :)

But at that point, maybe a more general git-remote-url library would be more useful?

Yes, it would, I was just wondering if it wouldn't benefit more to contribute to this library to before creating yet another one.

@RichardLitt
Copy link

Yeah! Sweet. I'm just a contributor, but I think this sounds good to me. :)

@Deuchnord
Copy link
Contributor Author

OK, I'll make a PR ASAP, then :)

@RichardLitt
Copy link

Cool! note - I am not a maintainer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants