Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark mode doesn't work well with tables #93

Closed
kunalmodi opened this issue Dec 3, 2021 · 2 comments
Closed

Dark mode doesn't work well with tables #93

kunalmodi opened this issue Dec 3, 2021 · 2 comments

Comments

@kunalmodi
Copy link

Table cell color isn't set as expected in dark mode:

Screen Shot 2021-12-02 at 6 20 44 PM

It should likely be forced to var(--color-fg-default)

Minimal Example:

<meta name="viewport" content="width=device-width, initial-scale=1">
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/github-markdown-css/5.0.0/github-markdown.min.css">
<style>
  .markdown-body {
    box-sizing: border-box;
    min-width: 200px;
    max-width: 980px;
    margin: 0 auto;
    padding: 45px;
  }

  @media (max-width: 767px) {
    .markdown-body {
      padding: 15px;
    }
  }
</style>
<article class="markdown-body">
  <h1>Unicorns</h1>
  <p>All the things</p>
  <table>
    <tr>
      <td>Hi</td>
    </tr>
  </table>
</article>
@hyrious
Copy link
Collaborator

hyrious commented Dec 3, 2021

Please add <!DOCTYPE html>, see https://stackoverflow.com/questions/24258380/font-color-in-a-table-doesnt-inherit-from-parent-div .

@kunalmodi
Copy link
Author

doh, appreciate the pointer @hyrious!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kunalmodi @hyrious