Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change isGitIgnoredSync and isGitIgnored #240

Closed
fisker opened this issue Nov 17, 2022 · 1 comment
Closed

Change isGitIgnoredSync and isGitIgnored #240

fisker opened this issue Nov 17, 2022 · 1 comment

Comments

@fisker
Copy link
Collaborator

fisker commented Nov 17, 2022

Currently isGitIgnoredSync work like this

isGitIgnoredSync({cwd})(file)

and isGitIgnored work like this

(await isGitIgnored({}))(file);

// Note the following doesn't work
await isGitIgnored({})(file);

Let's change them to

isGitIgnoredSync(file, {cwd})

and

await isGitIgnored(file, {cwd});
@fisker
Copy link
Collaborator Author

fisker commented Nov 17, 2022

I'll rethink about this #239 (comment)

@fisker fisker closed this as completed Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant