Fixes exception in a top path edge case #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The gitignore is throwing an exception when dealing with absolute paths if that path is the very same as the working directory. This is the case when both `expandDirectories: false` and `onlyFiles: false` are set and the input is `.` and the `cwd` is set to an absolute path. I ran across this when using `globby` in a project of mine and I reproduced it with a test case here and then fixed it.
fisker
reviewed
Dec 9, 2022
fisker
approved these changes
Dec 10, 2022
voxpelli
pushed a commit
to SocketDev/socket-cli-js
that referenced
this pull request
Dec 12, 2022
Makes workaround redundant for bug described in sindresorhus/globby#242
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gitignore is throwing an exception when dealing with absolute paths if that path is the very same as the working directory.
This is the case when both
expandDirectories: falseandonlyFiles: falseare set and the input is.and thecwdis set to an absolute path.I ran across this when using
globbyin a project of mine and I reproduced it with a test case here and then fixed it.