Adding 'data' event handler breaks output

[techniq]

I'm using multistream to stream multi API pages through the same stream (as suggested in issue #108) but I've ran into an issue. The API returns an empty array for pages that exceed the dataset so I need to "peek" at the data in the stream to know if I've reached the end. Using the example under stephenplusplus/stream-faqs as reference, if I add a stream.on('data', function() { ... }), no output is piped to process.stdout when using got.stream(). The issue does not occur when using request.

var MultiStream = require('multistream')
var got = require('got')
//var request = require('request')

var count = 0;
function factory (cb) {
  if (count > 3) return cb(null, null)
  count++
  var stream = got.stream('https://www.random.org/integers/?num='+count+'&min=1&max=6&col=1&base=10&format=plain&rnd=new')
  //var stream = request('https://www.random.org/integers/?num='+count+'&min=1&max=6&col=1&base=10&format=plain&rnd=new')

  stream.on('data', function() {
  })

  setTimeout(function () {
    cb(null, stream)
  }, 100)
}

MultiStream(factory).pipe(process.stdout);

[floatdrop]

Thats because you dump all data to on('data', function () { ... }), this is not an issue with got. Use through2 to peek into stream.

[techniq]

Hmm, I just tried to add a a through2 transform to my pipeline that just passes data through and I still go no output when using got.stream but works fine with request. Sorry, I'm just getting into using streams so it might be something simple.

var MultiStream = require('multistream')
var through2 = require('through2')
var got = require('got')
var request = require('request')

var count = 0;
function factory (cb) {
  if (count > 3) return cb(null, null)
  count++
  var stream = got.stream('https://www.random.org/integers/?num='+count+'&min=1&max=6&col=1&base=10&format=plain&rnd=new')
  // var stream = request('https://www.random.org/integers/?num='+count+'&min=1&max=6&col=1&base=10&format=plain&rnd=new')

  stream.pipe(through2(function (chunk, enc, callback) {
    this.push(chunk)
    callback()
  }))

  setTimeout(function () {
    cb(null, stream)
  }, 100)
}

MultiStream(factory).pipe(process.stdout);

[floatdrop]

Try this:

stream = stream.pipe(through2(function (chunk, enc, callback) {
    this.push(chunk)
    callback()
  }))

[techniq]

@floatdrop Thanks, that worked. It's odd that request works without setting the stream instance back onto the same variable. I tested with fs.createReadStream and it behaves like got.stream. Thanks again for your help.