beforeRequest doesn't merge options.json

[nghiepdev]

Hi,

I have custom options.json in beforeRequest hook, but it not working well.

Describe the bug

• Node.js version: ^14
• OS & version: macOS
• Got: ^11.5.2

Actual behavior

import got from 'got';

const client = got.extend({
  prefixUrl: 'https://domain.com',
  hooks: {
    beforeRequest: [
      options => {
        if (options.method === 'post' || options.method === 'POST') {
          options.json = options.json ?? {};
          options.json.myValue = 'newValue';

          // Debug here: I see data correctly
          console.log(options.json);
        }
      },
    ],
  },
});

client.post('my-api", {
  json: {
    ok: "ok"
  }
});

In fact, myValue doesn't merge with options.json data.

Checklist

• I have read the documentation.
• I have tried my code with the latest version of Node.js and Got.

[szmarczak]

Because it's converted into options.body.

[nghiepdev]

Is there ways to merge with options.json instance defaults?

[szmarczak]

Try this:

const client = got.extend({
  prefixUrl: 'https://domain.com',
  hooks: {
    beforeRequest: [
      options => {
        if (options.method === 'post' || options.method === 'POST') {
          options.json = options.json ?? {};
          options.json.myValue = 'newValue';
		  options.body = JSON.stringify(options.json);
        }
      },
    ],
  },
});

[szmarczak]

I think you should use the init hook instead. Let me know if that fixes the issue.

[nghiepdev]

options.body = JSON.stringify(options.json); doesn't work.

I cant' use the init hook. Because the options.context in the init hook is undefined.
I need some data in context.

[szmarczak]

I think we can pass a Proxy instance instead and normalize the options again if something changes.

[Giotino]

options.body = JSON.stringify(options.json); doesn't work.

Same problem here, also some explanations:
#1427 (comment)

[szmarczak]

options.body = JSON.stringify(options.json); doesn't work.

Ah... I just forgot that:

Because it's converted into options.body.

So you'd have to

const client = got.extend({
  prefixUrl: 'https://domain.com',
  hooks: {
    beforeRequest: [
      options => {
        if (options.method === 'post' || options.method === 'POST') {
          options.json = JSON.parse(options.body);
          options.json.myValue = 'newValue';
		  options.body = JSON.stringify(options.json);
        }
      },
    ],
  },
});

I cant' use the init hook. Because the options.context in the init hook is undefined.

In the upcoming release this will be possible. The init hook now accepts a second argument: self. So if context is defined in the instance, you can access context via self.context.

---

Yet another solution is to use the stringifyJson option.

---

Another way is to pass the body in the context and stringify it inside beforeRequest hooks. Note that you will have to update the content-length header as well.