Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable UNIX domain sockets #2046

Open
2 tasks
sindresorhus opened this issue May 25, 2022 · 3 comments
Open
2 tasks

Add option to disable UNIX domain sockets #2046

sindresorhus opened this issue May 25, 2022 · 3 comments
Labels
enhancement This change will extend Got features ✭ help wanted ✭

Comments

@sindresorhus
Copy link
Owner

sindresorhus commented May 25, 2022

https://github.com/sindresorhus/got/blob/main/documentation/tips.md#unix-domain-sockets

It's a niche feature and have heard that some teams have their own custom code to prevent it, so it makes sense to have the ability to turn it off in Got.

I suggest:

  • Add option to turn off support for UNIX domain sockets. Make it false by default.
  • In Got v13 (next major release), change it to be true by default.

Open questions:

  • Should a Unix socket be able to redirect to HTTP?
@sindresorhus sindresorhus added enhancement This change will extend Got features ✭ help wanted ✭ labels May 25, 2022
@TommyDew42
Copy link
Contributor

Haha, I'll pick up this one!
So when the setting is turned to false, the following won't work?

got('unix:/var/run/docker.sock:/containers/json');

@sindresorhus
Copy link
Owner Author

@TommyDew42 Correct. Also the http: version, per the docs.

@prsmahajan

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This change will extend Got features ✭ help wanted ✭
Projects
None yet
Development

No branches or pull requests

3 participants