Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable gzip support in options #24

Closed
floatdrop opened this issue Dec 15, 2014 · 3 comments
Closed

Disable gzip support in options #24

floatdrop opened this issue Dec 15, 2014 · 3 comments

Comments

@floatdrop
Copy link
Contributor

fetch library have option to disable gzip. Since we enforcing ungzip on response, wouldn't it be nice to have option to disable it?
@sindresorhus
Copy link
Owner

Why?

According to its docs it was only needed because of an old buggy Node version:

disableGzip set to false, to disable content gzipping, needed for Node v0.5.9 which has buggy zlib

@floatdrop
Copy link
Contributor Author

@sindresorhus to fetch gzipped content and store it. This is very rare usecase.

@sindresorhus
Copy link
Owner

Yeah, I don't see the point of that. We should optimize for the common case. For super edge-cases like these people can use request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sindresorhus @floatdrop