'encoding' option doesn't change output

[rightaway]

If I set the like this got.stream(url, { encoding: 'latin1' }), it doesn't seem to change the output as I would have expected for the file contents. I then tried changing the encoding string to a random string, and got didn't report any error. Is the encoding option being used? I'm using version 6.6.3.

Same with setting the option to null, it should return a Buffer but doesn't seem to change anything.

[floatdrop]

@rightaway can you post code snippet, that reproduces error?

[sindresorhus]

From the Node.js docs:

Note: Today's browsers follow the WHATWG spec which aliases both 'latin1' and ISO-8859-1 to win-1252. This means that while doing something like http.get(), if the returned charset is one of those listed in the WHATWG spec it's possible that the server actually returned win-1252-encoded data, and using 'latin1' encoding may incorrectly decode the characters. - https://nodejs.org/api/buffer.html#buffer_buffers_and_character_encodings

[rightaway]

Does it mean I need to change 'latin1' to 'win-1252' in the code sample above? I've tried it but still the same result. How can I get it to output the file as expected?

[sindresorhus]

I don't know. The Node.js docs are unclear about what you should do. I guess the safest thing to do would be to manually convert using something like https://github.com/ashtuchkin/iconv-lite