got.extend() doesn't merge hooks

[dima-takoy-zz]

I am try to get options dict for modifing it later. But looks like hook never been called.

'use strict'
const got = require('got')

const client = got
  .extend({
    baseUrl: 'https://jsonplaceholder.typicode.com/todos/1',
    json: true,
    hooks: {
      beforeRequest: [(options) => console.log(111111111111)],
    },
  })
  .get('/')
  .then(console.log)
  .catch(console.error)

got version: 9.2.1
node version: v10.10.0

[dima-takoy-zz]

hm, if i pass hook to .get('/') function then it works.

const got = require('got')

const noop = () => {}

const hooks = {
  beforeRequest: [console.log],
}

const client = got.create({
  options: {
    baseUrl: 'https://google.com',
    hooks,
  },
})

// not works
client
  .get('/')
  .then(noop)
  .catch(noop)

// works
client
  .get('/', { hooks })
  .then(noop)
  .catch(noop)

[szmarczak]

Can you elaborate where's the problem?

[dima-takoy-zz]

How i can define global hooks?

when i replace handler i got "compiled" options, where query already attached to url.

So my solution is wrong. It just replaces hooks(as described here) https://github.com/sindresorhus/got#gotmergeoptionsparentoptions-newoptions

[szmarczak]

What do you mean by "global hooks"?

[dima-takoy-zz]

What do you mean by "global hooks"?

Hooks that works for all children of instance. With extend we can add hooks. We can also manage hooks inside hooks. Now, when i use extend hooks are just replaces.

Can you elaborate where's the problem?

'use strict'

const got = require('got')

const noop = () => {}

const hooks = {
  beforeRequest: [console.log],
}

const client = got.create({
  options: {
    baseUrl: 'https://google.com',
    hooks,
  },
})

// hooks here, OK!
console.log(client.defaults.options.hooks)

// but it not works, hook not called
client
  .post('/')
  .then(noop)
  .catch(noop)

// when i pass directly hooks will be called
client
  .post('/', { hooks })
  .then(noop)
  .catch(noop)

[szmarczak]

Confirmed bug:

test('hooks are merged on got.extend()', t => {
	const hooksA = [() => {}];
	const hooksB = [() => {}];

	const instanceA = got.create({options: {hooks: {beforeRequest: hooksA}}});

	const extended = instanceA.extend({hooks: {beforeRequest: hooksB}});
	t.deepEqual(extended.defaults.options.hooks.beforeRequest, hooksA.concat(hooksB));
});

EDIT: fixed the test

Difference:

    [
      Function {},
  +   Function {},
    ]