Custom retry.retries function unexpectedly breaks statusCode and other conditional retries

[unikoid]

Since retry.statusCodes and retry.errorCodes option support is implemented as part of the default retries function, those options are incompatible with custom retry function. Moreover even default statusCodes become not working so you get retries for HTTP 401, for example.
This is not quite obvious and documentation says nothing about that.

I think this is a bug to be fixed or at least it should be stated in readme.

---

IssueHunt Summary

szmarczak has been rewarded.

Backers (Total: $60.00)

• issuehunt ($60.00)

Submitted pull Requests

• #830 Don't break the default behavior when using custom retry function

---

Tips

• Checkout the Issuehunt explorer to discover more funded issues.
• Need some help from other developers? Add your repositories on IssueHunt to raise funds.

---

IssueHunt has been backed by the following sponsors. Become a sponsor

[gonejack]

And retries would not work with stream API which documentation should state it.

[gregory]

And retries would not work with stream API which documentation should state it.

Oh man! I just spent hours trying to figure out why this wasn't working!
Should definitely be documented.

[IssueHuntBot]

@IssueHunt has funded $60.00 to this issue.

---

• Submit pull request via IssueHunt to receive this reward.
• Want to contribute? Chip in to this issue via IssueHunt.
• Checkout the IssueHunt Issue Explorer to see more funded issues.
• Need help from developers? Add your repository on IssueHunt to raise funds.

[issuehunt-oss]

@sindresorhus has rewarded $54.00 to @szmarczak. See it on IssueHunt

• 💰 Total deposit: $60.00
• 🎉 Repository reward(0%): $0.00
• 🔧 Service fee(10%): $6.00