Unexpected ParseErrorwhen using afterResponse with json

[fider]

Unexpected parse error thrown by got in specific case described below.

How to reproduce:

1. Use got@9.6.0
2. Set default options json:true
3. Get example afterResponse hook from docs (eg. basic auth to bearer token)
4. Do request where bearer token is invalid and afterResponse should obtain new bearer token

Unexpected parse error will be thrown.

Details:

• File as-promise.js
• line 62 ( response.body = JSON.parse(response.body); )
• response.body is already parsed to json object (second pase throws error)
• afterResponse hook is async function and uses await getNewToken(). getNewToken is using another got instance to obtain token. Default option json is true for both got instances. No other differences between docs and my code.

szmarczak earned $80.00 by resolving this issue!

• Checkout the Issuehunt explorer to discover more funded issues.
• Need some help from other developers? Add your repositories on Issuehunt to raise funds.

[szmarczak]

That's because the parsed response is passed to the original asPromise instance, and it tries to parse it again. Adding responseType: 'text' here should fix it. We need to make sure there are no things left like this.

[IssueHuntBot]

@IssueHunt has funded $80.00 to this issue.

---

• Submit pull request via IssueHunt to receive this reward.
• Want to contribute? Chip in to this issue via IssueHunt.
• Checkout the IssueHunt Issue Explorer to see more funded issues.
• Need help from developers? Add your repository on IssueHunt to raise funds.

[IssueHuntBot]

@sindresorhus has rewarded $72.00 to @szmarczak. See it on IssueHunt

• 💰 Total deposit: $80.00
• 🎉 Repository reward(0%): $0.00
• 🔧 Service fee(10%): $8.00