got.stream does not handle HPE_HEADER_OVERFLOW errors

[kapouer]

• Node.js version: 10.15.2
• OS & version: linux debian/buster

When the requested url sends >= 8KB http headers

got.stream('/hpe').pipe(mywritestream)

throws an unhandled rejection corresponding to a RequestError, code 'HPE_HEADER_OVERFLOW', message 'Parse Error'.

I suppose it should handle emit an error on the stream ?

[sindresorhus]

You could increase the allowed header size: https://stackoverflow.com/a/55298067

Not really anything to handle for Got or you as the steam is already in an error state at that point.

[sindresorhus]

Oh sorry, I missed that it was "unhandled". .pipe() doesn't forward errors (which I incredible dumb). However, you can use Stream.pipeline instead, which properly forwards errors. We should definitely update our docs to use that instead.

[kapouer]

TIL Stream.pipeline ! Awesome !