Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swallows errors inside of callback #84

Closed
ArtskydJ opened this issue Jul 18, 2015 · 2 comments
Closed

Swallows errors inside of callback #84

ArtskydJ opened this issue Jul 18, 2015 · 2 comments

Comments

@ArtskydJ
Copy link

It seems like got silently swallows errors.

var got = require('got')

got('http://josephdykstra.com', function (err, data) {
    console.log('i see this message')
    throw new Error('lolwut')
    console.log('but not this message')
})

process.on('uncaughtException', function(err) {
    console.log('error: ' + err)
})
C:\Users\Michael\Github\javascript\just-login-emailer\test>node test2.js
i see this message

C:\Users\Michael\Github\javascript\just-login-emailer\test>
@floatdrop
Copy link
Contributor

Thanks! This bug from read-all-stream and fixed in 3.0.1 version. Update please.

@shinnn
Copy link

shinnn commented Jul 18, 2015

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants