Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad commit instead of PR #8

Closed
julien-f opened this issue Sep 23, 2014 · 2 comments
Closed

Bad commit instead of PR #8

julien-f opened this issue Sep 23, 2014 · 2 comments
Assignees
@sindresorhus

Comments

@julien-f
Copy link
Contributor

I wanted to create a PR via the GitHub interface but I inadvertently committed directly instead.

Feel free to revert the commit if it does not seem correct to you.

Sorry for this :/
@sindresorhus
Copy link
Owner

No worries. I've done that multiple times by accident too. Lgtm. Feel free to commit directly if you're not looking for review ;)

Shortened it a2501bf and did a patch release. Thanks :)

@floatdrop
Copy link
Contributor

@julien-f if you can - move shared code from sent and got - it would be awesome 🌟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sindresorhus sindresorhus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sindresorhus @julien-f @floatdrop