promise API throws errors instead of rejecting promise

[dylang]

I believe it's an anti-pattern to synchronously throw errors in promises.

Example:

var mightBeFalse = false;
got(mightBeFalse)
    .then(doStuff)
    .catch(handleRejectedPromise); 

got synchronously throws

Parameter `url` must be a string or object, not boolean

Instead of rejecting the promise which would be handled by handleRejectedPromises.

[floatdrop]

@dylang yeah, errors in Promise API should be returned as rejected promises. Good catch 👍

[dylang]

Thanks @floatdrop!