Skip to content
This repository has been archived by the owner on Jan 24, 2021. It is now read-only.

Use HTML5 Notification instead of the display-notification module #29

Closed
zeakd opened this issue Jan 20, 2017 · 6 comments
Closed

Use HTML5 Notification instead of the display-notification module #29

zeakd opened this issue Jan 20, 2017 · 6 comments

Comments

@zeakd
Copy link
Contributor

zeakd commented Jan 20, 2017

It seems better to use BrowserWindow and html5 Notification instead of displayNotification. It solve #23 and looks better because it shows icon. also for window, linux support.

@sindresorhus
Copy link
Owner

Sure. PR welcome :)

@sindresorhus sindresorhus changed the title use html5 Notification instead of displayNotification. Use HTML5 Notification instead of the display-notification module Jan 20, 2017
@zeakd
Copy link
Contributor Author

zeakd commented Feb 8, 2017

@sindresorhus How about node-notifier?

@sindresorhus
Copy link
Owner

@zeakd I don't really see the point when Electron has it built-in through the browser window.

@zeakd
Copy link
Contributor Author

zeakd commented Feb 13, 2017

for OS support. The difference is Electron just can open Chromium based window which have HTML5 Notification API, and node-notifier is an abstraction of some notification systems. node notifier OS support

@sindresorhus
Copy link
Owner

I'm aware of how it works, but node-notifier is, from previous experience, very buggy and I don't see much added value in the extra maintenance overhead when HTML5 notifications solves our specific use-case good enough.

@sindresorhus
Copy link
Owner

Closing as this app is now deprecated.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants