Bug: Ignores --silent (Fix inside)

[bid]

This plugin seems to write to stdout even when you start gulp with --silent!

[bid]

Fixed it:

@@ -10,6 +10,7 @@
 module.exports = function (options) {
    options = assign({}, options || {});
    options.verbose = process.argv.indexOf('--verbose') !== -1;
+   options.silent = process.argv.indexOf('--silent') !== -1;

    var totalBytes = 0;
    var totalSavedBytes = 0;
@@ -78,7 +79,7 @@
        msg += totalFiles === 1 ? 'image' : 'images';
        msg += chalk.gray(' (saved ' + prettyBytes(totalSavedBytes) + ' - ' + percent.toFixed(1).replace(/\.0$/, '') + '%)');

-       gutil.log('gulp-imagemin:', msg);
+       if ( !options.silent ) gutil.log('gulp-imagemin:', msg);
        cb();
    });
 };

[kevva]

This should be handled by gulp itself and not on plugin level.

[bid]

"--silent" is one of the official gulp CLI arguments - and it works for every gulp plugin I use except this one. (I've build my own logger and always use that option, so gulps own output doesn't interfere). I haven't checked though, how the other plugin authors handle this option.

Re-reading the code I'd say this should be handled by the log function of gulp-utils. Maybe it should be logged as a bug there?

P.S.: "--verbose" is handled by the plugin too. How is that different?

[sindresorhus]

Yes, gulp-util.