-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to jasmine 4 #105
Comments
馃憤 |
The issues, explainedI spent several hours yesterday taking a look at the updates in this branch and how the gulp-jasmine tests interact with the Jasmine 4 engine. Here's what I found:
I know the Jasmine folks have deprecated engine shutdown, but without a granular way to determine which part of the suite is reporting errors, this seems premature IMO. (This might have changed in Jasmine 5 alpha, more investigation needed.) Why this mattersNone of these changes would matter if all the
Some architectural suggestionsIn order to run a comprehensive suite of tests for
A note about promise rejectionFinally, just a reminder that
|
If anyone wants to work on this, see the initial attemp in #106 |
Hi @sindresorhus,
Would you be interested in a PR to migrate to Jasmine 4?
If you're ok, I can work on this and submit a PR, otherwise no worries 馃槈
Thanks!
The text was updated successfully, but these errors were encountered: