-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jasmine test browserified code #6
Comments
@sindresorhus is it because |
@deepak1556 yeah I was just about to post. @sindresorhus would you merge if I made a fork of gulp-jasmine which takes file content instead of the path? If it just takes the path, that partially defeats the purpose of using Gulp over Grunt, since I'd need to write the browserified code to a temp file and then read it again. |
@JacksonGariety yes |
Perhaps eval with |
@shuhei Nvm, the gulp-jasmine variables would clash with the user's variables. |
Stuck on an error where jasmine continually throws If someone wants to take a look: https://github.com/jacksongariety/gulp-jasmine |
you tried to expose EDIT: Why not create a new context and rewire the methods as you are doing now and run |
It would be nice to make a pull request to minijasminenode instead of copying it into gulp-jasmine. I guess |
@deepak1556 that's what I've discovered, working on that now. @shuhei I was thinking add minijasminenode back, and simply do not use the index file, only jasmine-1.3.1 and the other two addons. |
@shuhei but minijasminenode never gains access to the actual data from the stream, it gets pushed and array of files. |
@deepak1556 but you can't |
Going to switch to mocha now, this doesn't work but it may be close: https://github.com/jacksongariety/gulp-jasmine |
@JacksonGariety you can try to shim require with giving the relative path to modules like this inside a vm https://github.com/google/tracing-framework/blob/8bdbffb19453a102917201866c36ed750c668495/bin/trace-runner.js#L67 but yeah there is another problem prototype properties of the sandbox wont be available inside the |
I think using Since Jasmine 2.0 is out now. It might just make more sense to use it directly. |
I'm trying to get gulp to build/transform my code with browserify/envify, and then test the transformed code with jasmine.
The browserify works:
However when I pipe it into jasmine, I get failing tests which show code that is not reactified/envified:
The text was updated successfully, but these errors were encountered: