Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not creating manifest correctly #255

Closed
muuvmuuv opened this issue Mar 18, 2019 · 7 comments
Closed

Not creating manifest correctly #255

muuvmuuv opened this issue Mar 18, 2019 · 7 comments

Comments

@muuvmuuv
Copy link

muuvmuuv commented Mar 18, 2019

Description

In my project I have multiple sources that have multiple sub-sources and each is concatenated in a separate file. That is why I have used a loop to create tasks dynamically. Somehow rev is not handle that correctly. It always produces just one or some of the files I push to the gulp taks.

Steps to reproduce

  1. Use my gulpfile.js
  2. create a src-folder with mark.js and `plyr.js``
  3. install required dependencies from gulpfile
  4. run gulp
@muuvmuuv
Copy link
Author

Seems to work with base set to the src or dist folder but then the manifest file is created in the root not in the dist folder where I want it to have.

@muuvmuuv
Copy link
Author

Final solution: ....pipe(rev.manifest(${DEST}/manifest.json, { base: SRC, merge: true })) which is in my humble opinion not very neat.

@Ritish-Madan
Copy link

@muuvmuuv I am too facing the same problem as you are facing. rev-manifest is not producing all the sources from which I am building the gulp.

As per your solution. Can you please elaborate the keyword DEST and SRC? Are they a keyword or the destination and source locations of your files to be built?

@muuvmuuv
Copy link
Author

Uhm, yes, those are variables (as you can see by ${). The formatting just break because of the backtick.

@Ritish-Madan
Copy link

Exactly, I tried something like ${/public/assets}/'manifest.json'. It stopped creating the manifest file. Can you please share a sample code you have used?

@muuvmuuv
Copy link
Author

No, not this way man. ${} is the syntax to include variables inside template literals. I am not longer using that lib and idk how the initial config looked like but from my snippet it should look like this with static paths.

//...
...pipe(
  rev.manifest('./manifest.json', { 
    base: './',
    merge: true
  })
)

@Ritish-Madan
Copy link

Got that dude, Thank you for the help. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants