Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

execution fails if not using vinyl-fs on gulp 3.x #28

Closed
Blaimi opened this issue Nov 20, 2019 · 3 comments
Closed

execution fails if not using vinyl-fs on gulp 3.x #28

Blaimi opened this issue Nov 20, 2019 · 3 comments

Comments

@Blaimi
Copy link
Contributor

Blaimi commented Nov 20, 2019

node_modules/gulp-tar/index.js:28
		if (file.isSymbolic()) {
		         ^

TypeError: file.isSymbolic is not a function
@Blaimi Blaimi changed the title execution fails if not using vinyl-fs execution fails if not using vinyl-fs on gulp 3.x Nov 20, 2019
@sindresorhus
Copy link
Owner

Gulp v3 is not supported:

"gulp": ">=4"

@Blaimi
Copy link
Contributor Author

Blaimi commented Nov 20, 2019

yes, but it's only a peer-dependency ;)

It's up to you if you want to merge or close without merging #29. A solution is using vinyl-fs.src instead of gulp.src. Even with resolveSymlinks: true (default) the isSymbolic() is implemented.

@sindresorhus
Copy link
Owner

yes, but it's only a peer-dependency ;)

The whole point of peer dependencies is to define that something works with a certain package without having to depend on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants