-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create-hash instead crypto.createHash #9
Comments
I don't see how this is my responsibility? It should be up to Browserify to replace the code correctly. That's the whole point of Browserify, being able to use node modules in the browser without having to care. Seems like the correct solution would be to improve the Browserify detection/replacement logic. |
just for you information:
|
@fanatid I didn't mean you were wrong. Just that you're trying to fix it in the wrong place. Your way, you'll have to try to convince every single module using |
@sindresorhus I agree that browserify should do this, but it's looks super hard |
You won't really know that until it's explored though, so I would still strongly encourage you to open an issue on Browserify to start a discussion about it. As for an immediate solution. Dead-code elimination comes to mind. Both Webpack 2 and Rollup supports that. |
if somebody will use this package with browserify bundle size will be awful
you can use createHash (part of crypto-browserify) for decrease bundle size without speed loss
The text was updated successfully, but these errors were encountered: