Skip to content
This repository has been archived by the owner on Sep 18, 2021. It is now read-only.

Doesn't work on macOS Sierra #4

Closed
nehayward opened this issue Oct 13, 2016 · 5 comments
Closed

Doesn't work on macOS Sierra #4

nehayward opened this issue Oct 13, 2016 · 5 comments

Comments

@nehayward
Copy link

nehayward commented Oct 13, 2016

No description provided.

@sindresorhus
Copy link
Owner

Tests are passing for me on macOS Sierra. You're gonna have to provide some more info if you want me to look into this. Preferably a failing test.

@sindresorhus sindresorhus changed the title Mac OS Sierra Doesn't work on macOS Sierra Oct 14, 2016
@nehayward
Copy link
Author

Is this not the same issue you have. I couldn't get URLs from your function. https://github.com/josh-/CloudyTabs/issues/33

@mcdado
Copy link

mcdado commented Oct 14, 2016

$ node
> const tabs = require('icloud-tabs');
undefined
> tabs.sync()
[ { deviceId: 'WebFeedSubscriptionsKey',
    deviceName: undefined,
    modified: Invalid Date,
    tabs: [] },
  { deviceId: '11111111111-2222-3333-AAAA-BBBBBBBBBBB',
    deviceName: undefined,
    modified: Invalid Date,
    tabs: [] },
  { deviceId: '11111111111-2222-3333-AAAA-BBBBBBBBBBB',
    deviceName: undefined,
    modified: Invalid Date,
    tabs: [] },
  { deviceId: '11111111111-2222-3333-AAAA-BBBBBBBBBBB',
    deviceName: undefined,
    modified: Invalid Date,
    tabs: [] } ]
>

I modified the hex deviceIds, just to anonymise.

@lukaskollmer
Copy link

The problem is that, since High Sierra, ~/Library/SyncedPreferences/com.apple.Safari.plist is encrypted. However, it appears that iCloud tab information can also be loaded from ~/Library/Safari/CloudTabs.db, which is not encrypted.

(see https://github.com/kmarchand/iCloudTabsAlfredWorkflow for reference, their implementation works fine on High Sierra)

@sindresorhus
Copy link
Owner

That requires full-disk access now, which mean the user has to manually add the Terminal or whatever is used to an allow list. That's just not feasible, so I'm just going to deprecate this package.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants