Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some problems, please help me, thk #16

Closed
blazer233 opened this issue Jan 10, 2023 · 1 comment
Closed

some problems, please help me, thk #16

blazer233 opened this issue Jan 10, 2023 · 1 comment

Comments

@blazer233
Copy link

const done = new Set();

Why should define: const done = new Set();

i think

 for(const i in returnValue){
    typeof i === 'string'
  }

if (done.has(filenameStem) || can be replaced with if (!!returnValue[filenameStem]) ||

@blazer233 blazer233 changed the title There are some problems, please help me, thk some problems, please help me, thk Jan 10, 2023
@sindresorhus
Copy link
Owner

I'm not sure what you are proposing, but the proper way to propose changes is to submit a pull request (and making sure the tests pass with the change).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants