Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: option to disable fallback #4

Closed
colinking opened this issue Sep 16, 2019 · 1 comment · Fixed by #5
Closed

Feature request: option to disable fallback #4

colinking opened this issue Sep 16, 2019 · 1 comment · Fixed by #5
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@colinking
Copy link
Contributor

re:

For unsupported terminals, the link will be printed in parens after the text: My website (https://sindresorhus.com).

What do you think of adding an optional boolean prop that indicates whether or not to perform this fallback? (fallback: boolean?) It should default to performing the fallback (the current behavior), so that it is backwards compatible.

I'm working on a CLI where I've sprinkled in some links, but I've found that links are sometimes just supplied purely for convenience. In that case, ideally the fallback would be disabled since it just takes up valuable space in the CLI output!

Would be happy to open a PR if so. I would just conditionally override the fallback parameter from terminal-link.

@sindresorhus
Copy link
Owner

Makes sense. PR welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants