Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow parsing of API_KEY to get more info from geo.ipify.org/api [Suggestion] #21

Closed
obayomi96 opened this issue Dec 29, 2023 · 2 comments

Comments

@obayomi96
Copy link

Thank you for this useful API.
I was working with it and wanted to use the geo.ipify api to get more details like ISP, since ipify api does does not support this out of the box unless you use the geo.ipify api and create an apikey to add to the endpoint url.

  • If possible, it would be cool to add the geo.ipify api endpint as well to the list of constants and call that if the user provides a valid api key to the ipify() function; e.g ipify(API_KEY).
  • If this would be useful, if need be I can make this addition myself if contributions are accepted. I did not see a contribution guild file so I decided to raise an issue to ask the team.

Cheers.

@sindresorhus
Copy link
Owner

Thanks for the suggestion. It's not something I plan to add to this package. I prefer to keep it simple and focused on only getting the IP address.

@sindresorhus sindresorhus closed this as not planned Won't fix, can't repro, duplicate, stale Dec 29, 2023
@obayomi96
Copy link
Author

Thanks for the suggestion. It's not something I plan to add to this package. I prefer to keep it simple and focused on only getting the IP address.

Great, understood. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants