Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question: Should we consider fs/promises a builtin module? #5

Closed
fisker opened this issue Apr 21, 2021 · 3 comments · Fixed by #6
Closed

Question: Should we consider fs/promises a builtin module? #5

fisker opened this issue Apr 21, 2021 · 3 comments · Fixed by #6
Labels
enhancement help wanted

Comments

@fisker
Copy link
Contributor

fisker commented Apr 21, 2021

See title
@fisker fisker mentioned this issue Apr 21, 2021
Closed
@sindresorhus
Copy link
Owner

sindresorhus commented Apr 21, 2021 •
edited

Yes, and all the other sub-exports, like timers/promises, etc.

We also need to add support for node: here.

@fisker
Copy link
Contributor Author

fisker commented Apr 21, 2021

I'll work on it.

Don't switch to ESM before fixing it, since we are going to use it in eslint-plugin-unicorn and ESLint rules don't support ESM. 😄

@sindresorhus
Copy link
Owner

Don't switch to ESM before fixing it, since we are going to use it in eslint-plugin-unicorn and ESLint rules don't support ESM. 😄

👍

@fisker fisker mentioned this issue Apr 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Recognize alias modules and node: protocol fisker/is-builtin-module
2 participants
@sindresorhus @fisker