Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needs more test cases #7

Closed
Lwdthe1 opened this issue May 30, 2018 · 2 comments
Closed

Needs more test cases #7

Lwdthe1 opened this issue May 30, 2018 · 2 comments

Comments

@Lwdthe1
Copy link

Lwdthe1 commented May 30, 2018

Thanks for this module. I just noticed some failed tests

The url example.png is not an image, but is-image says it is an image

The url example.png?size=1&color=b is an image, but is-image says that it is not an image, and I think its because of the query string

@sindresorhus
Copy link
Owner

From the top of the readme:

It just checks the extension. Use image-type if you want to check the actual file.

@Lwdthe1
Copy link
Author

Lwdthe1 commented May 30, 2018

Ah, thanks for pointing that out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants