We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
there is a check for a writable stream
isStream.writable = function (stream) { return stream.writable !== false && typeof stream._write === 'function' && typeof stream._writableState === 'object'; };
if you do this:
const z = fs.createWriteStream(dest); z.write('summa'); z.end(); return z;
calling end() will set writable to false, but it's still a writable stream, it's just no longer writable.
end()
do you think this is a bug or is this the desired behavior? I think it would be better to remove that check to see if writable !==false...
The text was updated successfully, but these errors were encountered:
then again, if end is called, you may not be able to listen to events because all the events may have already fired, kind of a weird one.
Sorry, something went wrong.
This was added due to #1. And yeah, technically, it's not a writable stream anymore since you can't write to it.
checkOpen
I have opened #20 which fixes this.
Successfully merging a pull request may close this issue.
there is a check for a writable stream
if you do this:
calling
end()
will set writable to false, but it's still a writable stream, it's just no longer writable.do you think this is a bug or is this the desired behavior? I think it would be better to remove that check to see if writable !==false...
The text was updated successfully, but these errors were encountered: