Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

we missed one pattern, news: #5

Closed
revelt opened this issue Dec 19, 2019 · 2 comments
Closed

we missed one pattern, news: #5

revelt opened this issue Dec 19, 2019 · 2 comments
Labels
enhancement help wanted

Comments

@revelt
Copy link

revelt commented Dec 19, 2019 •
edited

I was doing checks against all examples of URI's given in https://www.ietf.org/rfc/rfc2396.txt and noticed their example, news:comp.infosystems.www.servers.unix is reported wrongly.

Do you think it's worth to supplement the regex with news:?
@sindresorhus
Copy link
Owner

Sure

@revelt
Copy link
Author

revelt commented Dec 24, 2019

Waait, we're using url-regex, there's nothing to do here, let's raise an issue there instead.

@revelt revelt closed this as completed Dec 24, 2019
@revelt revelt mentioned this issue Dec 24, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sindresorhus @revelt