Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Case (in)sensitivity? (Desktop.ini can be desktop.ini) #19

Closed
dprothero opened this issue Apr 17, 2023 · 1 comment · Fixed by #20
Closed

Case (in)sensitivity? (Desktop.ini can be desktop.ini) #19

dprothero opened this issue Apr 17, 2023 · 1 comment · Fixed by #20

Comments

@dprothero
Copy link
Contributor

On Windows, I noticed I had desktop.ini and it wasn't getting filtered out because the code looks for Desktop.ini. I could propose a PR to make the pattern ^[Dd]esktop.ini$, but I wonder if it should just universally ignore case?
@sindresorhus
Copy link
Owner

I could propose a PR to make the pattern ^[Dd]esktop.ini$, but I wonder if it should just universally ignore case?

I think it's best to simply handle this specific case. Making it ignore case for everything could have other side-effects.

@dprothero dprothero mentioned this issue Apr 17, 2023
Merged
@dprothero dprothero changed the title Case (in)sensitivity? Case (in)sensitivity? (Desktop.ini can be desktop.ini) Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Desktop.ini may also be desktop.ini dprothero/junk
2 participants
@sindresorhus @dprothero