Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer own version of node-fetch or allow users to specify it #20

Closed
paambaati opened this issue May 29, 2020 · 2 comments
Closed

Prefer own version of node-fetch or allow users to specify it #20

paambaati opened this issue May 29, 2020 · 2 comments

Comments

@paambaati
Copy link

paambaati commented May 29, 2020

I just reported an issue on the Next.js issue tracker that concerns ky-universalvercel/next.js#13549

tl;dr

The body timeout issue on parsing large JSON responses still happens with v0.7.0 when using Next.js.

A contributor pointed out (see vercel/next.js#13549 (comment)) that this is happening because ky-universal is preferring global fetch over the latest beta version (own dependency). How do you propose we solve this?

One option I can think of is letting users inject their version of node-fetch. Another way to solve this would be expose a flag to force-use the bundled version of node-fetch.

Are there better solutions?

@belgattitude
Copy link
Contributor

Affected as well...

I like the idea to use recommended version... By recommended I mean the version ky-universal use for its tests (the latest is node-fetch v3.beta.x).

Not sure if it's possible to drive this by params... maybe a separate export import ky from 'ky-universal-full...

@sindresorhus
Copy link
Owner

This package is no longer needed if you target Node.js 18 or later: https://github.com/sindresorhus/ky/releases/tag/v1.0.0

@sindresorhus sindresorhus closed this as not planned Won't fix, can't repro, duplicate, stale Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants